Skip to content

Conversation

@K1ngst0m
Copy link

The dependency() for stb and glm first searched for system-installed versions, which could an incompatible version (e.g. stb_image_resize2.h), it may break the build.

By forcing the use of the subproject wrap files, it will prevent breaking changes due to unpredictable system dependency versions.

the `dependency()` for stb and glm first searched for system-installed versions,
which could an incompatible version (e.g. `stb_image_resize2.h`), it may break the build.

By forcing the use of the subproject wrap files, it will prevent breaking changes
due to unpredictable system dependency versions.
@misyltoad misyltoad merged commit 72bae17 into ValveSoftware:master Apr 25, 2025
@K1ngst0m K1ngst0m deleted the dev/use_wrap_file branch April 28, 2025 14:15
@K900
Copy link

K900 commented May 14, 2025

As a distro packager, this is actually causing new issues for us. I understand the temptation to tightly control dependency versions, but unless there's specific technical reasons for it, we would prefer to build with the shared libraries we already have.

@misyltoad
Copy link
Collaborator

stb and glm are both header only libraries.

@K900
Copy link

K900 commented May 14, 2025

Yes, but it is still preferable to use the versions we already ship.

@K1ngst0m
Copy link
Author

As a distro packager, this is actually causing new issues for us. I understand the temptation to tightly control dependency versions, but unless there's specific technical reasons for it, we would prefer to build with the shared libraries we already have.

Thanks for the advice. I think it’s better to provide override options for build dependency paths. I’ve added the glm_include_dir and stb_include_dir options in PR #1846.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants