DRMBackend: Fix HDR static metadata creation for PQ EOTF via lua config #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HDR10 infoframe creation was nested inside the EDID parsing block, so it only ran when HDR info came from the EDID. If a PQ EOTF was set via lua config, bHasKnownHDRInfo would be true, the EDID block would be skipped, and pDefaultMetadataBlob would never be created. Move the infoframe creation outside the EDID parsing block and gate it on HDR10 so the metadata is created whenever PQ output is configured, regardless of whether the HDR info came from lua config or EDID. We still use the EDID metadata when undefined in the lua config, or when there is no config for a PQ-compatible display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HDR10 infoframe creation was nested inside the EDID parsing block, so it only ran when HDR info came from the EDID. If a PQ EOTF was set via lua config, bHasKnownHDRInfo would be true, the EDID block would be skipped, and pDefaultMetadataBlob would never be created.
Move the infoframe creation outside the EDID parsing block and gate it on HDR10 so the metadata is created whenever PQ output is configured, regardless of whether the HDR info came from lua config or EDID.
We still use the EDID metadata when undefined in the lua config, or when there is no config for a PQ-compatible display.