Preliminary 7.4 Update #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'll hold onto this until dalamud is stabilised just in case there are any further changes they need to make, but absent any breakage, I'll get this merged and double check the combos once the stable release is out! |
| <Description>This plugin condenses various abilities onto single buttons.</Description> | ||
| <PackageProjectUrl>https://github.com/VariableVixen/XIVComboPlugin</PackageProjectUrl> | ||
| <Copyright>Copyleft attick 2020 baybeeee</Copyright> | ||
| <TargetFramework>net10.0-windows7.0</TargetFramework> |
Owner
There was a problem hiding this comment.
This line isn't needed if you're editing dalamud.props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick and preliminary 7.4 update.
I have not come across any issues so far and I don't think that any Job Adjustments are needed. VS2026 only "complains" about IClientState.LocalPlayer (CustomCombo.cs) being obsolete and to use IPlayerState or IObjectTable.LocalPlayer instead, if necessary.
The Plugin compiles nonetheless and seems to work fine. Only compiles against STAGING right now, so the Workflow Files would need to be changed to point to https://goatcorp.github.io/dalamud-distrib/stg/latest.zip.
EDIT:
ConfigWindow.cs, UpdateAlerter.cs, CustomCombo.cs, GameStatecs and IconRelacer.cs are showing Warnings.
IClientState.LocalPlayer being obsolete, same for IClientState.LocalContentId being obsolete.
EDIT:
Fixed the Warnings as well and updated the other CS files. Should be good to go. Either update Workflows or wait for Dalamud Release.