chore: github ci #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vauff
requested changes
Jul 3, 2024
Owner
Vauff
left a comment
Vauff
left a comment
There was a problem hiding this comment.
A lot of the SourceKnight concerns from Vauff/bspconvar_custom_whitelist#2 still seem to be relevant. But really, I only care about pinning to latest build of a SourceMod branch (https://sm.alliedmods.net/smdrop/1.11/sourcemod-latest-linux). Any update on implementing that?
And while I understand the previous justification for common in the build package in some situations. For most plugins like this, there are no assets to include in the release, and it's just a redundant folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see it in action here: