feat: add apple pay for web example #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dylan0916
reviewed
Oct 11, 2022
|
|
||
| throw 'ApplePay is not available'; | ||
| } | ||
| }); |
Member
Author
There was a problem hiding this comment.
just follow https://github.com/VeryBuy/react-native-tappay/blob/master/example/src/components/LINEPay/useLINEPay.ts#L18
as an example 應該只是要提升 erroe。
Contributor
There was a problem hiding this comment.
line pay 那邊沒有額外對 error 做什麼，catch 僅 log，但這邊沒 catch 會讓應用直接壞掉吧，僅是沒支援就壞掉不太合理
| throw 'ApplePay is not available'; | ||
| } | ||
| }); | ||
| TapPay.webSetupApplePay(merchantData, cartData); |
Contributor
There was a problem hiding this comment.
still run setup if isApplePayAvailable is false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.