Skip to content

Conversation

@hirokiterashima
Copy link
Member

This is a new feature for the grade by component feature branch.

This PR adds a new component, ComponentCompletionComponent, that shows the percentage of workgroups in the period that has completed the component. Previously, we were only able to show the completion for a node.

Changes

  • ComponentCompletionComponent shows percentage of workgroups in the period that has completed the component, from 0% to 100%

Test

  • Choose different nodes, components, and periods (including all periods). The completion percentage should display as described above.

@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Mar 10, 2025
@hirokiterashima hirokiterashima self-assigned this Mar 10, 2025
@hirokiterashima hirokiterashima changed the base branch from develop to grade-by-component March 10, 2025 20:52
@hirokiterashima hirokiterashima marked this pull request as ready for review March 10, 2025 20:58
@hirokiterashima hirokiterashima requested a review from breity March 10, 2025 20:58
hirokiterashima and others added 2 commits March 12, 2025 16:52
~ Conflicts:
~	src/assets/wise5/classroomMonitor/classroomMonitorComponents/component-grading-view/component-grading-view.component.html
~	src/assets/wise5/classroomMonitor/classroomMonitorComponents/component-grading-view/component-grading-view.component.ts
~	src/messages.xlf
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I updated to round the completion percentage to the nearest whole number.

Will work on styling in #2090.

@hirokiterashima hirokiterashima merged commit 22b15be into grade-by-component Mar 14, 2025
1 check passed
@hirokiterashima hirokiterashima deleted the component-completion branch March 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants