Skip to content

feat(OpenResponse): Summary display for teachers #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aaron-Detre merged 18 commits into from
Apr 15, 2025
Merged

feat(OpenResponse): Summary display for teachers #2135

Aaron-Detre merged 18 commits into from
Apr 15, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Apr 9, 2025 •
edited
Loading

Changes

  • Changed DialogGuidanceTeacherSummaryDisplayComponent to IdeasSummaryComponent which is used for both Dialog Guidance and Open Response.
  • Implemented sorting by idea ID

Test

  • Teacher Tools > Grade by step > Open Response component with CRater enabled > Step info
  • Make sure you can see the top 3 ideas detected (ordered from most common to least common) and the bottom 3 ideas detected (ordered from least common to most common).
  • Make sure the "see all ideas" link shows the all ideas section, sorted by ID (ex: 3 > 5 > 5a > 10).
  • Make sure the "hide all ideas" link hides the all ideas section.
  • Make sure that if no ideas have been detected, a message saying that ideas will show up here is displayed.
  • Also make sure that Dialog Guidance summary display still works.

Closes #2118

@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Apr 9, 2025
@Aaron-Detre Aaron-Detre self-assigned this Apr 9, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 10, 2025 19:27
hirokiterashima
hirokiterashima requested changes Apr 10, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Can you address the code change suggestions? I'll take another look when you're done.

hirokiterashima
hirokiterashima approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you address additional minor code improvement suggestions before merge?

@Aaron-Detre Aaron-Detre merged commit 526a807 into develop Apr 15, 2025
6 checks passed
@Aaron-Detre Aaron-Detre deleted the issue-2118-open-response-summary-display branch April 15, 2025 16:35
@hirokiterashima
Copy link
Member

hirokiterashima commented Apr 15, 2025

🎉 This PR is included in version 5.175.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(OpenResponse): Show detected ideas in summary display

3 participants

@Aaron-Detre @hirokiterashima