Skip to content

feat(Embedded): Grow model file name input vertically #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aaron-Detre merged 2 commits into from
Apr 15, 2025
Merged

feat(Embedded): Grow model file name input vertically #2136

Aaron-Detre merged 2 commits into from
Apr 15, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Apr 11, 2025

Changes

  • Changed the file name input field in the embedded component authoring tool to expand vertically for long URLs.

Test

  • Make sure that the input field grows vertically for long URLs.
  • Make sure that text entered in the input field is still saved and the desired file can still be retrieved.

Closes #2123

@Aaron-Detre Aaron-Detre self-assigned this Apr 11, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Apr 11, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 11, 2025 16:21
hirokiterashima
hirokiterashima approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaron-Detre Aaron-Detre merged commit 6088af3 into develop Apr 15, 2025
1 check passed
@Aaron-Detre Aaron-Detre deleted the issue-2123-grow-model-filename-vertically branch April 15, 2025 22:45
@hirokiterashima
Copy link
Member

hirokiterashima commented Apr 15, 2025

🎉 This PR is included in version 5.176.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(Embedded): Grow model filename input field vertically in authoring

3 participants

@Aaron-Detre @hirokiterashima