Skip to content

feat(CRater): Add model description to rubric #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aaron-Detre merged 8 commits into from
Apr 28, 2025
Merged

feat(CRater): Add model description to rubric #2139

Aaron-Detre merged 8 commits into from
Apr 28, 2025

Conversation

@Aaron-Detre
Copy link
Contributor

@Aaron-Detre Aaron-Detre commented Apr 15, 2025

Changes

  • Added a new description field to CRaterRubric.
  • Updated Dialog Guidance advanced settings to contain a new EditCRaterInfoComponent containing a new EditCRaterDescriptionComponent and the old EditCRaterIdeaDescriptionsComponent.

Test

  • In Dialog Guidance advanced settings:
    • Make sure that any changes made in the description editing field are saved to cRaterRubric.description in the project JSON.
    • Make sure that if there is anything in cRaterRubric.description in the project JSON, it appears in the description editing field.
    • Make sure that idea descriptions are still working as before.

@Aaron-Detre Aaron-Detre self-assigned this Apr 15, 2025
@Aaron-Detre Aaron-Detre added the enhancement New feature of any size or improvement (UI, performance, security) label Apr 15, 2025
@Aaron-Detre Aaron-Detre marked this pull request as ready for review April 15, 2025 23:47
hirokiterashima
hirokiterashima approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hirokiterashima hirokiterashima changed the title Add model description to CRater rubric feat(CRater): Add model description to rubric Apr 28, 2025
@Aaron-Detre Aaron-Detre merged commit 3f88120 into develop Apr 28, 2025
6 checks passed
@Aaron-Detre Aaron-Detre deleted the add-description-to-crater-rubric branch April 28, 2025 22:25
@hirokiterashima
Copy link
Member

hirokiterashima commented Apr 28, 2025

🎉 This PR is included in version 5.179.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@Aaron-Detre Aaron-Detre

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Aaron-Detre @hirokiterashima