Skip to content

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Remove remaining uses of FlexLayout

Test

  • Everything works as before

…-layout

~ Conflicts:
~	src/assets/wise5/components/animation/animation-student/animation-student.component.html
~	src/assets/wise5/components/discussion/discussion-student/discussion-student.component.html
~	src/assets/wise5/components/draw/draw-student/draw-student.component.html
~	src/assets/wise5/components/graph/graph-student/graph-student.component.html
~	src/assets/wise5/components/openResponse/open-response-student/open-response-student.component.html
~	src/assets/wise5/components/peerChat/peer-chat-student/peer-chat-student.component.html
~	src/messages.xlf
~ Conflicts:
~	src/assets/wise5/common/main-menu/main-menu.component.html
~ Conflicts:
~	src/app/news/news.component.html
~	src/app/teacher/manage-tags-dialog/manage-tags-dialog.component.ts
~	src/assets/wise5/authoringTool/add-project/add-project.component.ts
~	src/assets/wise5/authoringTool/structure/peer-review-and-revision/peer-review-and-revision.component.ts
~	src/assets/wise5/classroomMonitor/classroomMonitorComponents/manageStudents/manage-period/manage-period.component.html
~	src/assets/wise5/classroomMonitor/classroomMonitorComponents/manageStudents/manage-user/manage-user.component.ts
~	src/assets/wise5/classroomMonitor/classroomMonitorComponents/manageStudents/move-user-confirm-dialog/move-user-confirm-dialog.component.html
~	src/assets/wise5/classroomMonitor/classroomMonitorComponents/shared/tool-bar/tool-bar.component.ts
~	src/assets/wise5/classroomMonitor/dataExport/export-raw-data/export-raw-data.component.html
~	src/assets/wise5/classroomMonitor/dataExport/select-step-and-component-checkboxes/select-step-and-component-checkboxes.component.html
~	src/assets/wise5/components/audioOscillator/audio-oscillator-student/audio-oscillator-student.component.html
~	src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.html
~	src/assets/wise5/components/embedded/embedded-student/embedded-student.component.html
~	src/assets/wise5/directives/componentAnnotations/component-annotations.component.html
~	src/assets/wise5/directives/componentAnnotations/component-annotations.component.ts
~	src/assets/wise5/directives/generate-image-dialog/generate-image-dialog.component.html
~	src/assets/wise5/directives/node-navigation/node-navigation.component.ts
~	src/messages.xlf
@hirokiterashima hirokiterashima marked this pull request as ready for review September 19, 2025 16:42
Comment on lines 38 to +45
constructor(
private router: Router,
private breakpointObserver: BreakpointObserver,
private configService: ConfigService,
@Inject(DOCUMENT) private document: Document,
iconRegistry: MatIconRegistry,
private router: Router,
sanitizer: DomSanitizer,
utilService: UtilService,
media: MediaObserver,
private configService: ConfigService,
@Inject(DOCUMENT) private document: Document
utilService: UtilService
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 7): constructor [qlty:function-parameters]

@hirokiterashima hirokiterashima merged commit 8a1f89e into develop Sep 23, 2025
4 checks passed
@hirokiterashima hirokiterashima deleted the remove-remaining-flex-layout branch September 23, 2025 21:05
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.197.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants