Skip to content

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Convert HomePageProjectLibrary and ShareProjectDialog to standalone
  • Defer library loading on the homepage until it's in view, i.e., when you scroll down to it. This will save users from having to load the units and their thumbnails until they actually scroll to the section, which will improve the initial page load time.

Test

  • Homepage loads as before
  • "Curriculum Offerings" section of the homepage should load when it comes into view. You can test this by seeing that project_thumb.png's for the units are loaded when you scroll down to the section, not when the page is first loaded.
  • Unit Library page (/curriculum) works as before
  • Sharing units works as before

@hirokiterashima hirokiterashima changed the title feat(Homepage): Defer loading library until on viewport feat(HomeComponent): Defer loading library until on viewport Nov 14, 2025
@hirokiterashima hirokiterashima self-assigned this Nov 14, 2025
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Nov 14, 2025
@hirokiterashima hirokiterashima marked this pull request as ready for review November 14, 2025 00:31
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Is the @placeholder div necessary or can we just include the @defer content?

@hirokiterashima
Copy link
Member Author

Thanks. Yes, removing it will result in a compile-time error.

@hirokiterashima hirokiterashima merged commit 5dd3b77 into develop Nov 17, 2025
4 checks passed
@hirokiterashima hirokiterashima deleted the defer-loading-library-on-homepage branch November 17, 2025 18:44
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.199.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants