Conversation
Owner
|
Hey, thanks for the PR! |
Wikilicious
reviewed
Apr 7, 2025
pygmc/devices/auto_get_device.py
Outdated
| from .device_spec404 import DeviceSpec404 | ||
| from .gmc300 import GMC300, GMC300S, GMC300EPlus | ||
| from .gmc320 import GMC320, GMC320Plus, GMC320PlusV5 | ||
| from .gmc320 import GMC320, GMC320Plus, GMC320S, GMC320PlusV5 |
Owner
There was a problem hiding this comment.
The two spaces after GMC320S, is what's failing linter for this file
Owner
|
I don't have a contribution guide so that's on me... I'll make the edits on your PR. |
Owner
|
I realized I had incorrect information in the README. I listed GMC320S as supported, which I didn't have until you made this PR. |
Owner
|
@ffries I suspect your git commit email isn't listed in your https://github.com/settings/emails |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal pull-request for adding GMC-320S device. Thank you.