Skip to content

Conversation

@yeonjin719
Copy link
Member

🚨 관련 이슈

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

배포

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

@yeonjin719 yeonjin719 self-assigned this Aug 13, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 13, 2025

Caution

Review failed

The pull request is closed.

Summary by CodeRabbit

  • New Features
    • 푸시 알림(FCM) 지원: 브라우저 동의 후 토큰 등록, 알림 모달에서 무한 스크롤로 확인
    • 홈 화면 데이터 연동: 사용자 등급/이름, 데이트 횟수·저장 수·월별 장소 통계, 주간 키워드 워드클라우드, 지역별 날씨 추천·강수 차트
    • 지역 선택 모달 추가, 배너 슬라이드 개선(개별 이미지/전후 이동)
  • Style
    • Pretendard 폰트 적용, 반응형 레이아웃/버튼 크기 조정, 토글 라벨 커스터마이즈
  • Chores
    • 의존성 추가(firebase 등), 경로 별칭 설정 및 ESLint/TS 구성 업데이트

Walkthrough

FCM 기반 알림, 홈 대시보드 데이터(fetch/표시), 모달 인프라가 추가·확장되었습니다. Firebase SW/토큰 등록 훅, 알림 무한스크롤 모달, 지역 설정 모달, 홈 지표/날씨/키워드 API와 훅, 관련 타입/쿼리키/유틸이 신설되었습니다. 경로 별칭, 패키지, ESLint/TS 설정이 갱신되었습니다.

Changes

Cohort / File(s) Summary
Build & Config
eslint.config.mjs, tsconfig.json, tsconfig.app.json, package.json
ESLint ignore에 SW 추가, TS 경로 별칭(@/*) 설정, SW 파일 include, deps 추가(firebase, react-intersection-observer, react-spinners).
Firebase/FCM 알림
public/firebase-messaging-sw.js, src/firebase/firebase.ts, src/hooks/alarm/useDeviceToken.ts, src/api/alarm/alarm.ts, src/hooks/alarm/useGetAlarm.ts, src/types/alarm/alarm.ts, src/queryKey/queryKey.ts, src/components/modal/alarmModal.tsx, src/components/alarmModal/alarm.tsx, src/components/common/modalProvider.tsx, src/components/layout/Header.tsx, src/components/layout/MobileMenu.tsx
FCM SW/초기화/토큰 생성·등록 훅 추가, 알림 API/타입/쿼리키 생성, 알림 모달(무한스크롤) 및 아이템 컴포넌트 추가, 헤더/모바일 메뉴에서 모달 오픈 연동, 모달 프로바이더에 타입/매핑 추가.
Home API & Types & Utils
src/api/home/*(dateCourse.ts, dateTimes.ts, keyword.ts, level.ts, region.ts, weather.ts), src/types/home/*(dateCourse.ts, datePlace.ts, keyword.ts, level.ts, region.ts, weather.ts), src/constants/weather.ts, src/constants/chartOptions.ts, src/utils/*(getTodayString.ts, getNextSevenDay.ts, normalizeEmojiKey.ts, weatherMessage.ts), src/queryKey/queryKey.ts
홈 지표/날씨/지역/키워드 API와 타입 신설, 날씨/차트 옵션 상수 추가, 날짜/이모지 정규화/날씨 문구 유틸 추가, HomeKeys/NoticeKeys 추가.
Home Hooks
src/hooks/home/*(useDateCourseStates.ts, useDatePlaceStates.ts, useDateTimes.ts, useKeywordStates.ts, useUserGrade.ts, useUserRegion.ts, useWeather.ts), src/hooks/notices/useGetNotices.ts, src/hooks/customQuery.ts
각 홈 데이터 전용 쿼리 훅 및 지역 패치 뮤테이션 훅 추가, 공용 쿼리 훅의 staleTime 옵션화, 공지 무한스크롤 훅 신설.
Home Components
src/components/home/*(banner.tsx, dateCourseStore.tsx, dateLocation.tsx, dateRecommend.tsx, dateTimes.tsx, info.tsx, level.tsx, wordCloud.tsx)
배너 슬라이드별 이미지/내비 추가, 저장 수/월별 장소/날씨 추천/데이트 횟수/공지사항을 실데이터로 렌더링, 에러/로딩 처리, Level 컴포넌트 prop 기반으로 변경, 워드클라우드 데이터 연동 및 리사이즈 처리 개선.
Layout & Modal Infra
src/components/common/modalProvider.tsx, src/components/modal/regionModal.tsx, src/components/modal/SettingModal.tsx
모달 타입/매핑 확장(AlarmModal/RegionModal), 지역 검색/선택 모달 추가, SettingModal 사이즈 클래스 조정.
Settings & Common UI Tweaks
src/components/settingTab/*(AlarmSetting.tsx, InfoSetting.tsx, MembershipSetting.tsx), src/components/common/*(EditableInputBox.tsx, ToggleSwitch.tsx, graySvgButton.tsx)
반응형 레이아웃/여백 조정, ToggleSwitch에 on/off 레이블·className 옵션 추가, 버튼 child 타입을 ReactNode로 확장, 입력 박스 최대폭 대응.
Auth/Course API 경로 정리
src/api/auth/auth.ts, src/api/course/course.ts
axiosInstance 경로를 '@/api/axiosInstance'로 통합.
Notices 흐름 정리
src/api/notice/notice.ts, src/pages/notice/Notice.tsx, src/types/notice/notice.ts
공지 요청 타입 도입 및 파라미터 키(category→noticeCategory) 정식화, 페이지 컴포넌트 호출부 정합성 맞춤.
Home Page
src/pages/home/HomePage.tsx
FCM 토큰 트리거 훅 사용, 유저 등급 로딩/에러 처리 및 데이터 기반 렌더링(Level props 전달).
Styles
src/App.css
Pretendard CDN 폰트 추가 및 전역 폰트 패밀리 갱신.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant App as App(UI)
  participant Hook as useDeviceToken
  participant FB as Firebase(Messaging)
  participant SW as Service Worker
  participant API as Backend API

  U->>App: 첫 사용자 클릭
  App->>Hook: 초기화 트리거
  Hook->>FB: isSupported()
  alt 지원됨
    Hook->>SW: registerServiceWorker()
    Hook->>FB: generateToken()
    FB-->>Hook: token | null
    alt token 존재
      Hook->>API: POST /alarms/device-tokens
      API-->>Hook: 200 OK
    end
  end
Loading
sequenceDiagram
  autonumber
  participant UI as Header/MobileMenu
  participant Modal as ModalProvider
  participant AM as AlarmModal
  participant HQ as useGetAlarm
  participant API as GET /api/v1/alarms

  UI->>Modal: open(AlarmModal)
  Modal->>AM: mount
  AM->>HQ: useInfiniteQuery(init)
  HQ->>API: page=cursor,size=5
  API-->>HQ: alarmList, hasNext, cursor
  AM-->>AM: 목록 렌더
  AM->>AM: sentinel inView
  AM->>HQ: fetchNextPage()
  HQ->>API: cursor=last.cursor
  API-->>HQ: next page
  AM-->>AM: 추가 렌더
Loading
sequenceDiagram
  autonumber
  participant Home as HomePage
  participant HG as useUserGrade
  participant DR as DateRecommend
  participant UR as useGetUserRegion
  participant WF as useWeatherForecast
  participant RI as useRainyInfo
  participant DL as DateLocation/useMonthlyPlaceStates
  participant DT as DateTimes/useDateTimeStates
  participant KW as WordCloud/useWeeklyKeywords
  participant APIs as Home APIs

  Home->>HG: 등급 조회
  HG->>APIs: GET /members/grade
  APIs-->>HG: grade data
  Home-->>Home: Level 렌더

  DR->>UR: 지역 조회
  UR->>APIs: GET /regions/users/current
  APIs-->>UR: regionId

  DR->>WF: 주간 날씨 추천
  WF->>APIs: GET /weather/{regionId}/weekly
  APIs-->>WF: recommendations

  DR->>RI: 강수 정보
  RI->>APIs: GET /weather/{regionId}/precipitation
  APIs-->>RI: precipitations

  DL->>APIs: GET /logs/dateplaces/monthly
  DT->>APIs: GET /logs/datecourses/average
  KW->>APIs: GET /logs/keyword/weekly
Loading
sequenceDiagram
  autonumber
  participant UI as RegionModal
  participant SR as useSearchRegion
  participant UR as useUserRegion (mutation)
  participant API as Regions API

  UI->>SR: refetch(keyword)
  SR->>API: GET /regions/search?keyword
  API-->>SR: regions
  UI->>UR: patchUserRegion(regionId)
  UR->>API: PATCH /regions/users {regionId}
  API-->>UR: 200 OK
  UI-->>UI: onClose()
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • yujin5959
  • SEBINorSEBOUT
  • Seojegyeong

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13311b1 and c6fd58b.

⛔ Files ignored due to path filters (7)
  • src/assets/icons/weather/rain.svg is excluded by !**/*.svg
  • src/images/banner/bicycle.png is excluded by !**/*.png
  • src/images/banner/bukchon.png is excluded by !**/*.png
  • src/images/banner/itaewon.png is excluded by !**/*.png
  • src/images/banner/sungsu.png is excluded by !**/*.png
  • src/images/mainCharacter.png is excluded by !**/*.png
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock, !**/*.lock
📒 Files selected for processing (66)
  • eslint.config.mjs (1 hunks)
  • package.json (2 hunks)
  • public/firebase-messaging-sw.js (1 hunks)
  • src/App.css (1 hunks)
  • src/api/alarm/alarm.ts (1 hunks)
  • src/api/auth/auth.ts (1 hunks)
  • src/api/course/course.ts (1 hunks)
  • src/api/home/dateCourse.ts (1 hunks)
  • src/api/home/dateTimes.ts (1 hunks)
  • src/api/home/keyword.ts (1 hunks)
  • src/api/home/level.ts (1 hunks)
  • src/api/home/region.ts (1 hunks)
  • src/api/home/weather.ts (1 hunks)
  • src/api/notice/notice.ts (1 hunks)
  • src/components/alarmModal/alarm.tsx (1 hunks)
  • src/components/common/EditableInputBox.tsx (1 hunks)
  • src/components/common/ToggleSwitch.tsx (1 hunks)
  • src/components/common/graySvgButton.tsx (1 hunks)
  • src/components/common/modalProvider.tsx (2 hunks)
  • src/components/home/banner.tsx (2 hunks)
  • src/components/home/dateCourseStore.tsx (2 hunks)
  • src/components/home/dateLocation.tsx (1 hunks)
  • src/components/home/dateRecommend.tsx (1 hunks)
  • src/components/home/dateTimes.tsx (1 hunks)
  • src/components/home/info.tsx (2 hunks)
  • src/components/home/level.tsx (1 hunks)
  • src/components/home/wordCloud.tsx (3 hunks)
  • src/components/layout/Header.tsx (3 hunks)
  • src/components/layout/MobileMenu.tsx (2 hunks)
  • src/components/modal/SettingModal.tsx (1 hunks)
  • src/components/modal/alarmModal.tsx (1 hunks)
  • src/components/modal/regionModal.tsx (1 hunks)
  • src/components/settingTab/AlarmSetting.tsx (1 hunks)
  • src/components/settingTab/InfoSetting.tsx (1 hunks)
  • src/components/settingTab/MembershipSetting.tsx (3 hunks)
  • src/constants/chartOptions.ts (1 hunks)
  • src/constants/weather.ts (1 hunks)
  • src/firebase/firebase.ts (1 hunks)
  • src/hooks/alarm/useDeviceToken.ts (1 hunks)
  • src/hooks/alarm/useGetAlarm.ts (1 hunks)
  • src/hooks/customQuery.ts (1 hunks)
  • src/hooks/home/useDateCourseStates.ts (1 hunks)
  • src/hooks/home/useDatePlaceStates.ts (1 hunks)
  • src/hooks/home/useDateTimes.ts (1 hunks)
  • src/hooks/home/useKeywordStates.ts (1 hunks)
  • src/hooks/home/useUserGrade.ts (1 hunks)
  • src/hooks/home/useUserRegion.ts (1 hunks)
  • src/hooks/home/useWeather.ts (1 hunks)
  • src/hooks/notices/useGetNotices.ts (1 hunks)
  • src/pages/home/HomePage.tsx (2 hunks)
  • src/pages/notice/Notice.tsx (1 hunks)
  • src/queryKey/queryKey.ts (1 hunks)
  • src/types/alarm/alarm.ts (1 hunks)
  • src/types/home/dateCourse.ts (1 hunks)
  • src/types/home/datePlace.ts (1 hunks)
  • src/types/home/keyword.ts (1 hunks)
  • src/types/home/level.ts (1 hunks)
  • src/types/home/region.ts (1 hunks)
  • src/types/home/weather.ts (1 hunks)
  • src/types/notice/notice.ts (1 hunks)
  • src/utils/getNextSevenDay.ts (1 hunks)
  • src/utils/getTodayString.ts (1 hunks)
  • src/utils/normalizeEmojiKey.ts (1 hunks)
  • src/utils/weatherMessage.ts (1 hunks)
  • tsconfig.app.json (1 hunks)
  • tsconfig.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yeonjin719 yeonjin719 merged commit d23cd30 into main Aug 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants