Added the ability to configure which validators are of type "required" #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" (means that this validator will run, even if the field is not set on the input).
…" (means that this validator will run, even if the field is not set on the input).
…" (means that this validator will run, even if the field is not set on the input).
Contributor
|
Nice one, could you write the tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345
Basically, I've converted the variable
$require_type_of_rules(that was a hard-coded list of rules that will run even when the field is not present on the input) to a public static property into the configuration section (meaning that those values will be configurable when extending the GUMP class).