Move inline JS to external scripts #562
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dd32 is there more work expected on this or can this move out of draft for review on path towards merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #558 (That's fixed, but this is a more generic 'use the dependency system' PR)
What?
This migrates all inline JS from being inline and using jQuery to using Vanilla JS and external .js files.
This is not perfect JS, I'm no expert.
I've used dataset to pass the userId through, this should likely be replaced with a global JS object instead that contains it and the two-factor rest-api namespace.
Why?
Other than getting proper dependency loading as per #558, there's benefits in the code maintainability by splitting the HTML from the JS.
How?
Testing Instructions
Screenshots or screencast
Changelog Entry