Skip to content

Conversation

@theaminuli
Copy link
Member

@theaminuli theaminuli commented Oct 26, 2025

What?

Dashicons were not rendering correctly on several Make WordPress team sites (e.g., Hosting Handbook, Performance, AI, Program, Tide). The icons appeared as empty squares in places such as the “Show welcome box” option and the top bar beside some title.

Why?

The Dashicons stylesheet was not being enqueued as a dependency of the main theme stylesheet (wporg-breathe). As a result, the font files required for Dashicons were not loaded, causing missing or broken icon displays.

Fixes / Reference

This change adds dashicons as a dependency to the wp_enqueue_style() function that registers the wporg-breathe stylesheet, ensuring the Dashicons CSS is loaded consistently.

Fixes:

Files Changed:

functions.php

Updated Code:

wp_enqueue_style(
    'wporg-breathe',
    get_stylesheet_uri(),
    array( 'p2-breathe', 'dashicons' ),
    filemtime( __DIR__ . '/style.css' )
);

@dd32 or
@SergeyBiryukov , when you have a moment, could you please review this PR? Your feedback would be greatly appreciated.

@bazza bazza closed this in 900035c Oct 27, 2025
@theaminuli
Copy link
Member Author

Was there a problem with my pull request that caused you to close it? @bazza

@iqbal-web
Copy link

iqbal-web commented Oct 27, 2025

Here is the update of your pr @theaminuli
900035c

As it mirrors the version all pr closed, pr merge the other way.

@dd32
Copy link
Member

dd32 commented Oct 27, 2025

@theaminuli Apologies for the confusion, Bazza shows up here only because he's the one who owns the GitHub key used to sync WordPress.org SVN to GitHub.

This PR was effectively Merged in the above commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants