Fix: Add Dashicons dependency to ensure icons render correctly on Make WordPress sites #523
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Dashicons were not rendering correctly on several Make WordPress team sites (e.g., Hosting Handbook, Performance, AI, Program, Tide). The icons appeared as empty squares in places such as the “Show welcome box” option and the top bar beside some title.
Why?
The Dashicons stylesheet was not being enqueued as a dependency of the main theme stylesheet (
wporg-breathe). As a result, the font files required for Dashicons were not loaded, causing missing or broken icon displays.Fixes / Reference
This change adds
dashiconsas a dependency to thewp_enqueue_style()function that registers thewporg-breathestylesheet, ensuring the Dashicons CSS is loaded consistently.Fixes:
Files Changed:
functions.php
Updated Code:
@dd32 or
@SergeyBiryukov , when you have a moment, could you please review this PR? Your feedback would be greatly appreciated.