Update of php.md - Opening and Closing PHP Tags Section#63
Open
edocev wants to merge 1 commit intoWordPress:masterfrom
Open
Update of php.md - Opening and Closing PHP Tags Section#63edocev wants to merge 1 commit intoWordPress:masterfrom
edocev wants to merge 1 commit intoWordPress:masterfrom
Conversation
The Opening and Closing PHP Tags Section - Specifically the case of single lines PHP inside HTML blocks was unclear and not full. Please see the above-proposed suggestion for edit and further improve that part of the documentation
Member
|
Hi @edocev, can you just rebase your PR so that the latest changes are taken into the account? |
Member
|
Thanks, but let's not add verbiage defining what "must" be used here. I think before any further changes are added to the handbook for this a consensus on WordPress/WordPress-Coding-Standards#1085 should be reached. My suggestion is we close this issue and revisit once the above is resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Opening and Closing PHP Tags Section - Specifically the case of single lines PHP inside HTML blocks was unclear and not full. Please see the above-proposed suggestion for edit and further improve that part of the documentation