This repository was archived by the owner on Jul 26, 2018. It is now read-only.
Breakout Date Bounds into a Separate CSV #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqc_us_rules/dqc_us_0006.py
Outdated
| } | ||
| _CODE_NAME = 'DQC.US.0006' | ||
| _RULE_VERSION = '1.0' | ||
| _DEFAULT_DATE_BOUNDS_FILE = os.path.join(os.path.dirname(__file__), 'resources', 'DQC_US_0006', 'dqc_06_date_bounds.csv') |
Collaborator
There was a problem hiding this comment.
Split up on to multiple lines
dqc_us_rules/util/facts.py
Outdated
|
|
||
| def _fact_components_valid(fact): | ||
| """ | ||
| Return true if all of the components in a fact are none |
Collaborator
|
+1 |
added 8 commits
March 8, 2016 16:18
tests/unit_tests/test_dqc_us_0006.py
Outdated
| self.assertEqual(res3, expected) | ||
|
|
||
|
|
||
| class TestDateBoundsCVS(unittest.TestCase): |
Collaborator
There was a problem hiding this comment.
'CSV' instead of 'CVS'
tests/unit_tests/test_dqc_us_0006.py
Outdated
|
|
||
| self.assertDictEqual(DATE_BOUNDS_DICT, date_bounds_dict_from_csv) | ||
|
|
||
| def test_date_bounds_cvs_keys_unequal(self): |
Collaborator
There was a problem hiding this comment.
'csv' instead of 'cvs'
Collaborator
|
+1 |
1 similar comment
Collaborator
|
+1 |
Collaborator
|
+10 - tested with document originally used for DQC 6. Same number of validations fired. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please review: @hefischer @andrewperkins-wf