-
Notifications
You must be signed in to change notification settings - Fork 39
Revert "Update dependency google/apiclient to v2.18.3 (#585)" #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit bb600c4.
WalkthroughDependency versions in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
composer.json(2 hunks)
🔇 Additional comments (1)
composer.json (1)
28-28: No PHP 8.0+ syntax detected—downgrade to PHP 7.3 is safe.The codebase contains no PHP 8.0+ language features (match expressions, union types in signatures, named arguments, or nullsafe operators). Type unions found in the search results are only in PHPDoc comments, which are compatible with PHP 7.3.
| "ext-mbstring": "*", | ||
| "composer/installers": "2.3.0", | ||
| "google/apiclient": "2.18.3", | ||
| "google/apiclient": "2.13.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify codebase compatibility with google/apiclient 2.13.1.
This reverts to a significantly older version (2.13.1 vs. 2.18.3). Ensure that code using google/apiclient doesn't depend on APIs, behavior, or features introduced in versions 2.14.0–2.18.3.
Run the following to identify usages of the google/apiclient package in the codebase:
🏁 Script executed:
#!/bin/bash
# Search for direct usages of Google API client
rg -n 'Google\\' --type php -C 2Length of output: 1398
🏁 Script executed:
#!/bin/bash
# Extract the actual method calls and property accesses on Google API client classes
rg -n -A 5 'Google_Client|Google_Service_Calendar' includes/feeds/google.php --type php | head -100Length of output: 2182
🏁 Script executed:
#!/bin/bash
# Check if PHP version checks or PHP 8.1+ specific syntax is used in the codebase
rg -n 'PHP_VERSION|version_compare' includes/ --type php -C 2Length of output: 6886
🏁 Script executed:
#!/bin/bash
# Look for any explicit google/apiclient version constraints or compatibility checks
rg -n 'apiclient|Google.*2\.' . -C 1Length of output: 2254
Critical: PHP version mismatch between composer.json and code requirements.
The google/apiclient 2.13.1 downgrade is compatible with existing code—it uses only basic, stable API methods (setters, getters) that haven't changed across versions. However, this PR creates a conflict:
- composer.json line 55: PHP platform downgraded to
7.3 - includes/functions/admin.php line 440: Code requires minimum PHP
8.0
The codebase will fail with an error if PHP 7.3 is actually used. Either:
- Keep PHP platform at
8.0or higher in composer.json, or - Modify the PHP requirement check in includes/functions/admin.php to match the new platform version
🤖 Prompt for AI Agents
composer.json (line 34 and line 55) and includes/functions/admin.php (around
line 440): there is a PHP version mismatch — composer.json forces platform php
7.3 while admin.php enforces PHP >= 8.0; choose one fix and apply it
consistently: either update composer.json platform.php to "8.0" (or the actual
minimum required) and run composer update to regenerate lockfile, or change the
PHP requirement check in includes/functions/admin.php to accept 7.3 (or the
chosen platform version) so both files match; ensure the chosen version reflects
real code requirements and update related documentation/tests as needed.
Description: As per discussion I have merge the google API version change into main after as it is BFCM sale is running so we decide to release this in January Si revert the changes, but I am not able to directly push the code undo into main as it is required 1 approval, SO create this PR. I have to push other issue related code and release so first I need to undo this changes from main.
This reverts commit bb600c4.
Clickup: https://app.clickup.com/t/86d0dvv33