Skip to content

Conversation

@Akhill2020
Copy link
Contributor

@Akhill2020 Akhill2020 commented Nov 21, 2025

Description: As per discussion I have merge the google API version change into main after as it is BFCM sale is running so we decide to release this in January Si revert the changes, but I am not able to directly push the code undo into main as it is required 1 approval, SO create this PR. I have to push other issue related code and release so first I need to undo this changes from main.
This reverts commit bb600c4.

Clickup: https://app.clickup.com/t/86d0dvv33

@coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2025

Walkthrough

Dependency versions in composer.json were downgraded: google/apiclient from 2.18.3 to 2.13.1 and PHP platform support reduced from 8.1 to 7.3.

Changes

Cohort / File(s) Summary
Dependency Downgrades
composer.json
Downgraded google/apiclient from 2.18.3 to 2.13.1; reduced PHP platform requirement from 8.1 to 7.3

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify compatibility of google/apiclient 2.13.1 with existing code that may use features introduced in 2.18.3
  • Confirm PHP 7.3 compatibility with the rest of the codebase, particularly for any language features or functions used that require 8.1+

Suggested reviewers

  • enginnk

Poem

🐰 Down, down the versions go,
Simpler paths we now bestow,
PHP seven-three takes the stage,
Google's client turns the page,
Compatibility reigns supreme! 🌿

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reverting a dependency update from PR #585, which directly matches the actual changes in the changeset (downgrading google/apiclient and PHP version).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-merge-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Akhill2020 Akhill2020 requested a review from rosinghal November 21, 2025 08:24
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb600c4 and 60935a5.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • composer.json (2 hunks)
🔇 Additional comments (1)
composer.json (1)

28-28: No PHP 8.0+ syntax detected—downgrade to PHP 7.3 is safe.

The codebase contains no PHP 8.0+ language features (match expressions, union types in signatures, named arguments, or nullsafe operators). Type unions found in the search results are only in PHPDoc comments, which are compatible with PHP 7.3.

"ext-mbstring": "*",
"composer/installers": "2.3.0",
"google/apiclient": "2.18.3",
"google/apiclient": "2.13.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify codebase compatibility with google/apiclient 2.13.1.

This reverts to a significantly older version (2.13.1 vs. 2.18.3). Ensure that code using google/apiclient doesn't depend on APIs, behavior, or features introduced in versions 2.14.0–2.18.3.

Run the following to identify usages of the google/apiclient package in the codebase:


🏁 Script executed:

#!/bin/bash
# Search for direct usages of Google API client
rg -n 'Google\\' --type php -C 2

Length of output: 1398


🏁 Script executed:

#!/bin/bash
# Extract the actual method calls and property accesses on Google API client classes
rg -n -A 5 'Google_Client|Google_Service_Calendar' includes/feeds/google.php --type php | head -100

Length of output: 2182


🏁 Script executed:

#!/bin/bash
# Check if PHP version checks or PHP 8.1+ specific syntax is used in the codebase
rg -n 'PHP_VERSION|version_compare' includes/ --type php -C 2

Length of output: 6886


🏁 Script executed:

#!/bin/bash
# Look for any explicit google/apiclient version constraints or compatibility checks
rg -n 'apiclient|Google.*2\.' . -C 1

Length of output: 2254


Critical: PHP version mismatch between composer.json and code requirements.

The google/apiclient 2.13.1 downgrade is compatible with existing code—it uses only basic, stable API methods (setters, getters) that haven't changed across versions. However, this PR creates a conflict:

  • composer.json line 55: PHP platform downgraded to 7.3
  • includes/functions/admin.php line 440: Code requires minimum PHP 8.0

The codebase will fail with an error if PHP 7.3 is actually used. Either:

  1. Keep PHP platform at 8.0 or higher in composer.json, or
  2. Modify the PHP requirement check in includes/functions/admin.php to match the new platform version
🤖 Prompt for AI Agents
composer.json (line 34 and line 55) and includes/functions/admin.php (around
line 440): there is a PHP version mismatch — composer.json forces platform php
7.3 while admin.php enforces PHP >= 8.0; choose one fix and apply it
consistently: either update composer.json platform.php to "8.0" (or the actual
minimum required) and run composer update to regenerate lockfile, or change the
PHP requirement check in includes/functions/admin.php to accept 7.3 (or the
chosen platform version) so both files match; ensure the chosen version reflects
real code requirements and update related documentation/tests as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants