Skip to content

Lab8.1 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YehorYurch5 merged 19 commits into from
Nov 23, 2025

update

8a0fbab
Select commit
Loading
Failed to load commit list.
Merged

Lab8.1 #10

update
8a0fbab
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 23, 2025 in 23s

Quality Gate failed

Failed conditions
59.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 123 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call independent Assert statements from inside an Assert.Multiple 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbG&open=AZqxgnTTXiqAYiOWEgbG&pullRequest=10

Check warning on line 240 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use Assert.That(<collection>, Has.Length.EqualTo(<value>) 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbK&open=AZqxgnTTXiqAYiOWEgbK&pullRequest=10

Check warning on line 214 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use Assert.That(<collection>, Has.Length.EqualTo(<value>) 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbJ&open=AZqxgnTTXiqAYiOWEgbJ&pullRequest=10

Check warning on line 11 in NetSdrClientApp/Networking/TcpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this implementation of 'IDisposable' to conform to the dispose pattern. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnWdXiqAYiOWEgbM&open=AZqxgnWdXiqAYiOWEgbM&pullRequest=10

Check warning on line 16 in NetSdrClientApp/Networking/UdpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this implementation of 'IDisposable' to conform to the dispose pattern. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxqncCcJLzNz_vqntQ&open=AZqxqncCcJLzNz_vqntQ&pullRequest=10

Check warning on line 69 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call independent Assert statements from inside an Assert.Multiple 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbF&open=AZqxgnTTXiqAYiOWEgbF&pullRequest=10

Check warning on line 26 in NetSdrClientApp/Networking/TcpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this implementation of 'IDisposable' to conform to the dispose pattern. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnWdXiqAYiOWEgbL&open=AZqxgnWdXiqAYiOWEgbL&pullRequest=10

Check warning on line 35 in NetSdrClientApp/Networking/TcpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change NetworkStreamAdapter.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnWdXiqAYiOWEgbP&open=AZqxgnWdXiqAYiOWEgbP&pullRequest=10

Check warning on line 127 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use Assert.That(<collection>, Has.Length.EqualTo(<value>) 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbH&open=AZqxgnTTXiqAYiOWEgbH&pullRequest=10

Check warning on line 19 in NetSdrClientApp/Networking/TcpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change SystemTcpClientAdapter.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnWdXiqAYiOWEgbQ&open=AZqxgnWdXiqAYiOWEgbQ&pullRequest=10

Check warning on line 104 in NetSdrClientApp/Networking/TcpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Resource '_cts' has already been disposed explicitly or through a using statement implicitly. Remove the redundant disposal. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnWdXiqAYiOWEgbO&open=AZqxgnWdXiqAYiOWEgbO&pullRequest=10

Check warning on line 215 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Call independent Assert statements from inside an Assert.Multiple 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbI&open=AZqxgnTTXiqAYiOWEgbI&pullRequest=10

Check warning on line 50 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use Assert.That(<collection>, Has.Length.EqualTo(<value>) 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbD&open=AZqxgnTTXiqAYiOWEgbD&pullRequest=10

Check warning on line 30 in NetSdrClientAppTests/NetSdrMessageHelperTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use Assert.That(<collection>, Has.Length.EqualTo(<value>) 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnTTXiqAYiOWEgbE&open=AZqxgnTTXiqAYiOWEgbE&pullRequest=10

Check failure on line 166 in NetSdrClientApp/Networking/TcpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxgnWdXiqAYiOWEgbN&open=AZqxgnWdXiqAYiOWEgbN&pullRequest=10

Check warning on line 22 in NetSdrClientApp/Networking/UdpClientWrapper.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change Sha256Adapter.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. 

See more on https://sonarcloud.io/project/issues?id=YehorYurch5_NetSdrClient&issues=AZqxqncCcJLzNz_vqntR&open=AZqxqncCcJLzNz_vqntR&pullRequest=10
View more details on SonarQubeCloud