Make CURRENT_GIT_VERSION logic robust in release tarballs #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielG
force-pushed
the
use-export-subst
branch
from
044ff37 to
182db91
Compare
This automatically embeds git version information into tarballs built with git-archive. This even works for tarballs downloaded from Github. Essentially the same trick as in YosysHQ/yosys#3138 with one complication: git-tag information is not available to the export-subst (see gitattributes(5)) format string so we use the commit date instead. We retain the current git-describe based string for git checkouts but it might be advisable to align this to be the HEAD commit date plus commit hash too.
DanielG
force-pushed
the
use-export-subst
branch
from
182db91 to
f071c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically embeds git version information into tarballs built with git-archive. This even works for tarballs downloaded from Github.
Essentially the same trick as in YosysHQ/yosys#3138 with one complication: git-tag information is not available to the export-subst (see gitattributes(5)) format string so we use the commit date instead.
We retain the current git-describe based string for git checkouts but it might be advisable to align this to be the HEAD commit date plus commit hash too.