Add Page Preloading #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KojoZero is attempting to deploy a commit to the zxy101's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZXY101
reviewed
Feb 7, 2025
| export let src: FileWithBlob; | ||
| let url: string = ''; | ||
| // $: url = src ? `url(${URL.createObjectURL(src)})` : ''; |
Owner
There was a problem hiding this comment.
Suggested change
| // $: url = src ? `url(${URL.createObjectURL(src)})` : ''; |
Owner
|
Not really noticing much of an improvement on the flicker, also the changes seem to break the reader once you get to the last page and try to navigate. |
Collaborator
|
So this does make a huge improvement with flicker for volumes with exceptionally large images. However, the implementation results in considerable lag while paging and responsiveness issues when paging quickly. |
yuukibarns
pushed a commit
to yuukibarns/mokuro-reader
that referenced
this pull request
Jun 12, 2025
Add unit tests for Japanese character counting utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds page preloading, which prevents the screen flash that occurs when changing the page.