fix: prevent panic on malformed ISO9660 path table #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Add bounds checking in parsePathTable to prevent slice bounds out of range panic when parsing malformed ISO9660 images with truncated path table entries. Found by fuzzing: the path table entry's dirNameLen field could specify a length exceeding the remaining buffer, causing a panic when slicing.
wizzomafizzo
force-pushed
the
fix/iso9660-path-table-bounds
branch
from
110d8b6 to
c5214f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
parsePathTableto prevent slice bounds out of range panic when parsing malformed ISO9660 imagesBackground
The fuzzer found that malformed ISO9660 images with truncated path table entries could cause a panic. The path table entry's
dirNameLenfield could specify a length exceeding the remaining buffer, causing a slice bounds panic.Changes
i+8+dirNameLendoesn't exceed buffer length before slicingTest plan