Skip to content

Conversation

@agilyol
Copy link
Contributor

@agilyol agilyol commented Oct 25, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@agilyol agilyol requested a review from a team as a code owner October 25, 2025 03:29
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @agilyol, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the handling of protocol buffer messages within the a2a utility functions. It incorporates a more contemporary Python syntax for type checking and, crucially, ensures that protocol buffer extensions are correctly processed and included during message conversion, enhancing data integrity and consistency.

Highlights

  • Modernized Type Checking: The make_dict_serializable function in src/a2a/utils/proto_utils.py has been updated to use the more modern | operator for type unions (e.g., str | int | float | bool) instead of the tuple-based isinstance(value, (str, int, float, bool)) syntax. This improves readability and aligns with newer Python versions.
  • Proto Extension Handling: The message class method within src/a2a/utils/proto_utils.py now correctly includes the extensions field when constructing an a2a_pb2.Message object. This ensures that any protocol buffer extensions present in the input message are properly carried over, defaulting to an empty list if no extensions are provided.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with serializing protocol buffer extensions. The change to use modern union type syntax in isinstance is a good stylistic improvement. The main fix correctly adds the extensions field to the Message protobuf conversion.

My review includes one major point: the fix is incomplete. The Artifact type also has an extensions field that is not being handled in ToProto.artifact and FromProto.artifact. I've provided a detailed comment with suggestions on how to address this to make the fix comprehensive.

@holtskinner holtskinner changed the title fix: proto extensions fix(grpc): Add extensions to Artifact converters. Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants