-
Notifications
You must be signed in to change notification settings - Fork 448
test: fix broken unit test for go client send task streaming #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @vinbyte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a failing unit test within the Go client's send task streaming functionality. The issue stemmed from an incorrect method expectation in the test, which was asserting 'message/send' instead of the actual 'message/stream' being sent by the client. The change updates this assertion, ensuring the test accurately validates the client's behavior and now passes successfully. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a broken unit test for the Go client's streaming task sending functionality. The expected method in the test server was updated from message/send to message/stream, which aligns with the client's implementation. The change is straightforward and correct. I've added one minor suggestion to improve code style by avoiding a repeated magic string in the test assertion.
Description
The go client unit test sending
message/stream, but the server expectingmessage/send. This PR fixes the method checking in server side.before:

after:

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.