Skip to content

Conversation

@vinbyte
Copy link

@vinbyte vinbyte commented Sep 28, 2025

Description

The go client unit test sending message/stream, but the server expecting message/send. This PR fixes the method checking in server side.

before:
Screenshot 2025-09-28 at 09 23 19

after:
Screenshot 2025-09-28 at 09 23 51

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vinbyte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a failing unit test within the Go client's send task streaming functionality. The issue stemmed from an incorrect method expectation in the test, which was asserting 'message/send' instead of the actual 'message/stream' being sent by the client. The change updates this assertion, ensuring the test accurately validates the client's behavior and now passes successfully.

Highlights

  • Unit Test Fix: Corrected a broken unit test in the Go client for send task streaming.
  • Method Expectation: The test was incorrectly expecting the method 'message/send' when the client was sending 'message/stream'.
  • Assertion Update: Updated the test assertion to correctly check for 'message/stream', aligning it with the client's actual behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a broken unit test for the Go client's streaming task sending functionality. The expected method in the test server was updated from message/send to message/stream, which aligns with the client's implementation. The change is straightforward and correct. I've added one minor suggestion to improve code style by avoiding a repeated magic string in the test assertion.

@vinbyte vinbyte changed the title test: broken unit test for go client send task streaming test: fix broken unit test for go client send task streaming Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant