Skip to content

fix: log connection state when unable to attach #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owenpearson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: log connection state when unable to attach #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ably/realtime/realtime_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,14 @@ async def attach(self) -> None:
self.__error_reason = None

# RTL4b
if self.__realtime.connection.state not in [
connection_state = self.__realtime.connection.state
if connection_state not in [
ConnectionState.CONNECTING,
ConnectionState.CONNECTED,
ConnectionState.DISCONNECTED
]:
raise AblyException(
message=f"Unable to attach; channel state = {self.state}",
message=f"Unable to attach channel; connection state = {connection_state}",
code=90001,
status_code=400
)
Expand Down
Loading