chore: conditionally add OwnerReferences during resource creation for AutoScalingListener
#4224
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhychan
requested review from
a team,
mumoshu,
nikola-jokic,
rentziass and
toast-gear
as code owners
jhychan
changed the title
AutoScalingListenerOwnerReferences during resource creation for AutoScalingListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #4031 and building upon PR #3575
As per this comment, owner references cannot be cross-namespace. Since the default architecture for ARC is to install the runner scale sets in separate namespaces to the controllers and listeners, the owner reference for AutoScalingListeners cannot be set.
However, ARC can run in single-namespace configuration, which can be the same namespace as the runner scale sets. In this scenario, the ownerReference can be set on the AutoScalingListener.