Normalize paths for consistency across platforms using toMinimatchPath
#2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th` and add tests for Windows path handling + fixed windows path handling on item matching.
sandrohanea
added a commit
to sandrohanea/cuda-toolkit
that referenced
this pull request
Oct 5, 2025
Applied the fix from actions/toolkit#2154 and referenced the files directly
sandrohanea
added a commit
to sandrohanea/cuda-toolkit
that referenced
this pull request
Oct 5, 2025
Applied the fix from actions/toolkit#2154 and referenced the files directly
|
@Link-, @danwkennedy can you, please, take a look when you have some time? :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toMinimatchPathitemPathwas matchedFixes: #2085, #2063
Example CI where action using glob is now returning the windows path: https://github.com/sandrohanea/glob-test/actions/runs/18260828957/job/51988483881
Same action not returning it before the fix: https://github.com/sandrohanea/glob-test/actions/runs/18260757261/job/51988321083