Skip to content

fix: send promise token for non cs sites as well #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 4, 2025
Merged

fix: send promise token for non cs sites as well #1423

merged 8 commits into from
Nov 4, 2025
+69 −24

Conversation

@rpapani
Copy link
Contributor

@rpapani rpapani commented Oct 31, 2025 •
edited
Loading

  • for obtaining the executedBy we need the proper promiseToken. PromiseToken currently is being sent only for CS delivery type, as that was required by Content API earlier. Since we need the promiseToken to obtain the user email as well, sending this irrespective of the site delivery type
  • renamed getCSPromiseToken --> getIMSPromiseToken as this isn't only for CS any more

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

This PR will trigger a patch release when merged.

@rpapani rpapani marked this pull request as ready for review November 4, 2025 04:12
@rpapani rpapani requested review from alinarublea and ramboz November 4, 2025 04:12
ramboz
ramboz approved these changes Nov 4, 2025
View reviewed changes
Copy link

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@rpapani rpapani merged commit 2ca116b into main Nov 4, 2025
7 checks passed
@rpapani rpapani deleted the promise-token branch November 4, 2025 19:05
solaris007 pushed a commit that referenced this pull request Nov 4, 2025
@semantic-release-bot
chore(release): 1.223.9 [skip ci]
9b5d850 
## [1.223.9](v1.223.8...v1.223.9) (2025-11-04)

### Bug Fixes

* send promise token for non cs sites as well ([#1423](#1423)) ([2ca116b](2ca116b))
@solaris007
Copy link
Member

solaris007 commented Nov 4, 2025

🎉 This PR is included in version 1.223.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramboz ramboz ramboz approved these changes

@alinarublea alinarublea Awaiting requested review from alinarublea

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rpapani @solaris007 @ramboz