Two pages json.html and objects.html #81
Conversation
|
JSON support added in lib so language like java and C# easily create flowcharts |
|
can you delete all unneeded files? i.e release/* iml?, etc... |
|
No, I just rebuild the project |
|
ok, but you could revert them... because I will do the build when releasing a new version... |
|
Do you have any develop branch I will make marge request with that branch. And for this reject this pull requests |
|
no.... but if you want you can rebase your changes... |
|
Ok I will rebase release folder |
|
|
||
| window.onload = function () { | ||
| var btn = document.getElementById("run"), | ||
| cd = document.getElementById("code"), |
There was a problem hiding this comment.
Since you're already putting these on their own lines just declare the "var" for each. Makes your intentions a little clearer.
|
|
||
| var data = JSON.parse(code); | ||
|
|
||
| var symbols=data.symbols; |
|
|
||
| var symbolsArray ={}; | ||
| for(var key in symbols) | ||
| { |
There was a problem hiding this comment.
Are we going with this C style curly braces?
There was a problem hiding this comment.
Bad idea in JavaScript. Every newLine triggers a “Should a ; be auto inserted. In compiled languages like C and Java the position of the { is a question of taste (and a source of religious wars second only to tabs vs spaces). In JavaScript it matters. Keep them at line end.
| var direction=directions[key]; | ||
| directionsArray[direction.key+"_"+direction.nextKey+"_"+direction.next]=direction; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please make a note of these extra spaces and formatting between expressions.
|
|
||
|
|
||
| chart.drawSVG('canvas', { | ||
| // 'x': 30, |
| } | ||
| }); | ||
|
|
||
| $('[id^=sub1]').click(function(){ |
There was a problem hiding this comment.
What exactly is this supposed to do?
| var data = { | ||
| symbols: { | ||
| st: { | ||
| key: 'st', |
There was a problem hiding this comment.
Seems a bit like a maintenance nightmare to have a property in all these objects with the key name. You can always get the key name with builtin functionality.
4 participants
JSON support added in lib so language like java and C# easily create flowcharts