[pull] master from KelvinTegelaar:master #113
Merged
+177
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded the cippUser schema to include jitAdminStartDate and jitAdminCreatedBy properties. Added caching and loading of function permissions from JSON in Get-CIPPHttpFunctions and Invoke-ListFunctionParameters for improved performance and consistency. Refactored Set-CIPPUserJITAdmin to correctly set schema properties and extract CreatedBy from headers.
Replaces Write-AlertMessage with Write-LogMessage for better error reporting, including severity, API context, and detailed exception data.
Adds -ErrorAction SilentlyContinue and -Compress to ConvertTo-Json and ConvertFrom-Json calls for repository permissions. This change prevents errors from interrupting execution if JSON conversion fails and ensures more robust handling of permission data.
Added null-coalescing operators to ensure $Users and $ServicePrincipals are always arrays, preventing potential errors when responses or cached data are missing or null. Also added -ErrorAction SilentlyContinue to ConvertFrom-Json calls for more robust error handling.
Updated the logic to check for cached GitHub release notes to match the current major.minor version series using semantic versioning, instead of only matching the full release tag. This ensures that release notes are refreshed only when the major.minor version changes, improving cache efficiency.
Refactored location processing in New-CIPPCATemplate to reduce redundant API calls and ensure unique location info. Enhanced Set-CIPPCAPolicyServiceException with clearer logic, improved string handling, and added more informative logging. Minor bug fixes and code style improvements in Invoke-ExecCAServiceExclusion and New-CIPPCAPolicy for robustness.
Dev to hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )