-
-
Notifications
You must be signed in to change notification settings - Fork 20
fix(deps): update module github.com/google/go-github/v32 to v80 #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ce49e2d to
68420a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to ce49e2d in 2 minutes and 4 seconds. Click for details.
- Reviewed
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. go.mod:11
- Draft comment:
It appears that both github.com/google/go-github/v32 (v32.1.0) and github.com/google/go-github/v80 (v80.0.0) are required. If the intention is to update to v80, consider removing the old v32 dependency to avoid possible conflicts and confusion. Please confirm that any code still relying on v32 is updated accordingly. - Reason this comment was not posted:
Comment was on unchanged code.
2. go.mod:3
- Draft comment:
The Go version has been updated from 1.19 to 1.24.0. Ensure that your development environment and CI pipelines are configured with Go 1.24 or later. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically the Go version. It advises the PR author to ensure their environment is updated, which is not allowed by the rules. The comment does not provide a specific code suggestion or ask for a test to be written.
3. go.mod:3
- Draft comment:
Typo alert: The updated Go version is specified as "1.24.0". Typically, the version in go.mod is specified as "1.24" (without the patch version). Please verify if this is intentional. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is about a changed line in the diff, so it passes that test. However, there are several issues: 1) The comment asks the author to "verify if this is intentional" which is explicitly against the rules. 2) The comment is speculative - it says "typically" but doesn't definitively state this is wrong. 3) Go 1.24 doesn't exist yet (as of my knowledge), so this might be a test file or the version number itself might be incorrect, but the comment doesn't address that. 4) Even if the format is technically incorrect, this would likely be caught by Go tooling when runninggo mod tidyor building the project, which means it falls under "obviously caught by the build". The comment is asking for verification rather than stating a definitive issue. I might be wrong about whether the patch version format would be caught by Go tooling - it's possible Go accepts "1.24.0" format even if it's unconventional. Also, if this is indeed incorrect syntax, it might be valuable feedback even if phrased as a question. Even if the format might be accepted by Go, the comment explicitly asks the author to "verify if this is intentional" which directly violates the rule against asking for confirmation. The comment should either state definitively that this is wrong and needs to be fixed, or it shouldn't be made at all. Since it's phrased as a question/verification request, it should be deleted. Delete this comment because it asks the PR author to "verify if this is intentional" which violates the rule against asking for confirmation. The comment is speculative rather than definitive, and if the format is truly incorrect, it would likely be caught by Go tooling.
Workflow ID: wflow_xdKLmqnfX4lroni5
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
68420a8 to
115d086
Compare
115d086 to
241dd86
Compare
241dd86 to
45077f6
Compare
45077f6 to
f7e8720
Compare
f7e8720 to
78208cd
Compare
78208cd to
2eb3bb7
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/aevea?upgradeToPro=build-rate-limit |
3cea101 to
967d351
Compare
|
Deployment failed with the following error: Learn More: https://vercel.com/aevea?upgradeToPro=build-rate-limit |
967d351 to
d13357e
Compare
d13357e to
4b2138a
Compare
4b2138a to
6e2f585
Compare
6e2f585 to
1bd1ab4
Compare
1bd1ab4 to
a72fdf4
Compare
a72fdf4 to
d1c10f0
Compare
d1c10f0 to
a41c49d
Compare
a41c49d to
12d5586
Compare
12d5586 to
df49f58
Compare
df49f58 to
1c37819
Compare
1c37819 to
cfe8dca
Compare
cfe8dca to
a7d27ee
Compare
This PR contains the following updates:
v32.1.0→v80.0.0Release Notes
google/go-github (github.com/google/go-github/v32)
v80.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
ListProvisionedSCIMGroupsEnterpriseOptionsoptional fields are now pointers....and the following additional changes:
structfieldlinter to check struct field names and tags (#3843)v79.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
UpdateProjectItemOptions.Fieldis now[]*ProjectV2FieldUpdate.BREAKING CHANGES: Several
OrganizationsServicemethods have been renamed for better consistency.BREAKING CHANGE:
SCIMService.ListSCIMProvisionedGroupsForEnterpriseis nowEnterpriseService.ListProvisionedSCIMEnterpriseGroups....and the following additional changes:
required_reviewerssupport toPullRequestRuleParameters(#3806)jsonfieldnamelinter to support$injsontag names (#3826)v78.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGES: Various
EnterpriseServicestructs have been renamed for consistency....and the following additional changes:
sha_pinning_requiredtoActionsPermissionsstructs (#3807)v77.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
RepositoriesService.CreateStatusnow takes value forstatus, not pointer.BREAKING CHANGES:
ProjectV2Field.Optionschanged from[]anyto[]*ProjectV2FieldOption.ProjectV2Field.URLis nowProjectV2Field.ProjectURLProjectV2structs are now passed as pointersProjectsServicefunctions with #3761...and the following additional changes:
Authorizationwhentokenis available (#3789)v76.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE: ActionsBilling endpoints are removed.
GetRepositoriesForCodeSecurityConfiguration(#3707)BREAKING CHANGE: GetRepositoriesForCodeSecurityConfiguration now returns RepositoryAttachment instead of Repository.
BREAKING CHANGE: Permissions-related methods are renamed from
Edit*toUpdate*.BREAKING CHANGE:
GetDefaultCodeSecurityConfigurationsnow returnsCodeSecurityConfigurationWithDefaultForNewReposinstead ofCodeSecurityConfiguration.BREAKING CHANGE: Billing-related methods are renamed to pattern, and required fields are changed to value types.
...and the following additional changes:
v75.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
GitServicemethods now pass required params by-value instead of by-ref....and the following additional changes:
v74.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
ListSCIMProvisionedGroupsForEnterprisenow takesListSCIMProvisionedGroupsForEnterpriseOptionsinstead of*ListSCIMProvisionedIdentitiesOptions.BREAKING CHANGE: Change
ListCheckSuiteOptions.AppIDfrominttoint64...and the following additional changes:
v73.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
ListCustomPropertyValuesnow takesListCustomPropertyValuesOptionsinstead ofListOptions....and the following additional changes:
v72.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
MergeMethod*consts have been split into:PullRequestMergeMethod*andMergeQueueMergeMethod*.BREAKING CHANGE:
GetRulesForBranch,GetAllRulesets, andGetAllRepositoryRulesetsnow acceptopts....and the following additional changes:
v71.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
ListCommentReactionOptions=>ListReactionOptionsand allList*Reactionsmethods now use it....and the following additional changes:
v70.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
EnterpriseNetwork*structs have been replaced withNetwork*structs.BREAKING CHANGE:
PackageVersion.BodyandPackageVersion.Metadataare both nowjson.RawMessage....and the following additional changes:
v69.2.0Compare Source
This minor release contains the following changes:
v69.1.0Compare Source
This minor release contains the following changes:
v69.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
Create*RulesetandUpdate*Rulesetnow passrulesetparameter by-value instead of by-reference.BREAKING CHANGE:
Rerequstable=>Rerequestable,RunsRerequstable=>RunsRerequestableBREAKING CHANGE:
MergablePulls=>MergeablePulls,UnmergablePulls=>UnmergeablePullsBREAKING CHANGE: Some error strings are slightly modified - please do not rely on error text in general.
BREAKING CHANGES: The following types have been renamed:
Ruleset->RepositoryRulesetRulesetLink->RepositoryRulesetLinkRulesetLinks->RepositoryRulesetLinksRulesetRefConditionParameters->RepositoryRulesetRefConditionParametersRulesetRepositoryNamesConditionParameters->RepositoryRulesetRepositoryNamesConditionParametersRulesetRepositoryIDsConditionParameters->RepositoryRulesetRepositoryIDsConditionParametersRulesetRepositoryPropertyTargetParameters->RepositoryRulesetRepositoryPropertyConditionParameters->RepositoryRulesetRepositoryPropertyConditionParametersRulesetOrganizationNamesConditionParameters->RepositoryRulesetOrganizationNamesConditionParametersRulesetOrganizationIDsConditionParameters->RepositoryRulesetOrganizationIDsConditionParametersRulesetConditions->RepositoryRulesetConditionsRepositoryRulesetEditedChanges->RepositoryRulesetChangesRepositoryRulesetEditedSource->RepositoryRulesetChangeSourceRepositoryRulesetEditedSources->RepositoryRulesetChangeSourcesRepositoryRulesetEditedConditions->RepositoryRulesetUpdatedConditionsRepositoryRulesetUpdatedConditionsEdited->RepositoryRulesetUpdatedConditionRepositoryRulesetEditedRules->RepositoryRulesetChangedRulesRepositoryRulesetUpdatedRules->RepositoryRulesetUpdatedRulesRepositoryRulesetEditedRuleChanges->RepositoryRulesetChangedRuleBREAKING CHANGE:
ListOAuthAppsnow returns([]*OAuthApp, error)instead of([]OAuthApp, error).BREAKING CHANGE:
User.InheritedFromis changed from a*Teamto a[]*Team....and the following additional changes:
X-Ratelimit-Resourceheaders (#3453)v68.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE: All support for "Project (classic)" is removed and
Projectresponses are replaced byProjectV2(renamed fromProjectsV2).BREAKING CHANGE: The unused
Statsfield is removed from theCommitstruct....and the following additional changes:
v67.0.0Compare Source
This release contains the following breaking API changes:
BREAKING CHANGE:
optsargument toActionsService.ListArtifactschanged fromListOptionstoListArtifactsOptions.BREAKING CHANGE: Rename
RuleRequiredCodeScanningToolstoRuleRequiredCodeScanningTool.BREAKING CHANGE: Change
RulesetRepositoryPropertyTargetParameters.Sourcefromstringto*string....and the following additional changes:
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.