(refactor): use a map of chapters with list of refs #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- somewhat similar to how mangas work
- significantly simplify merge logic for chapters as we just need to
update the map entry and then update the list of refs to the new
order directly
- this also handles arbitrary additions of new chapters anywhere
in the list (that the previous version did not)
agilgur5
added
the
external blocker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the map entry and then update the list of refs to the new
order directly
in the list (that the previous version did not)
This is the more optimal fix for #21 and a follow-up PR to the simple fix in #22 .
WIP status as this is currently blocked by at least agilgur5/mst-persist#16 as it requires the persisted data to be migrated to the new format. That PR adds transforms to
mst-persist, on top of which we can add migrations. Still need to think about how to version the data appropriately.