prepare for relase 4.0.16 #449
Conversation
oliveregger
commented
Dec 28, 2025
oliveregger
commented
- adapt test and map for ("null" values in address line. #440)
- update to core 6.7.10 (update core to 6.7.10 #448)
- support validating CodeableConcept in internal tx (update core to 6.7.10 #448)
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @oliveregger, your pull request is larger than the review limit of 150000 diff characters
There was a problem hiding this comment.
Pull request overview
This PR prepares the matchbox project for version 4.0.16, updating the core FHIR library to version 6.7.10 and adding support for validating CodeableConcept in internal terminology services.
Key Changes:
- Update FHIR core library from 6.6.5 to 6.7.10
- Add support for CodeableConcept validation in internal terminology operations
- Add documentation for updating core version dependencies
- Implement check-references-to functionality for validation
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Update project version to 4.0.16 and core library to 6.7.10 |
| udpatecoreversion.md | New documentation file describing the core version update process |
| matchbox-server/with-ch/application.yaml | Update ch-core package version and reorder configuration |
| matchbox-server/.../CodeSystemProvider.java | Add CodeableConcept validation support |
| matchbox-server/.../TerminologyUtils.java | Add helper method for CodeableConcept response parameters |
| matchbox-server/.../CliContext.java | Add check-references-to parameter support and remove redundant annotations |
| matchbox-engine/.../InstanceValidator.java | Extensive updates to align with core 6.7.10 API changes |
| matchbox-engine/.../Params.java | Refactor parameter handling methods |
| matchbox-engine/.../ValidationPolicyAdvisor.java | Update constructor to accept referencesTo parameter |
| matchbox-engine/.../TerminologyCache.java | Format changes and add diagnostics field handling |
| changelog.md | Document changes for version 4.0.16 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <groupId>health.matchbox</groupId> | ||
| <artifactId>matchbox</artifactId> | ||
| <version>4.0.15</version> | ||
| <version>4.0.16</version> |
There was a problem hiding this comment.
The PR title indicates this is for release 4.0.15, but the version has been updated to 4.0.16. This inconsistency should be resolved.
| <version>4.0.16</version> | |
| <version>4.0.15</version> |
matchbox-server/src/main/java/ch/ahdis/matchbox/CliContext.java
Outdated
Show resolved
Hide resolved
| import org.hl7.fhir.instance.model.api.IBaseResource; | ||
| import org.hl7.fhir.instance.model.api.IIdType; | ||
| import org.hl7.fhir.r4.model.CodeSystem; | ||
| import org.hl7.fhir.r5.model.CodeSystem; |
There was a problem hiding this comment.
The import changed from r4 to r5 model for CodeSystem. Ensure this is intentional and that the matchbox-server module is intended to work with R5 models, or if this should remain as r4.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@oliveregger I've opened a new pull request, #450, to work on those changes. Once the pull request is ready, I'll request review from you. |
The CI was using Node.js 20 while local development uses Node.js 24. This version mismatch caused package-lock.json sync issues with npm ci. Updated angular_build.yml to use Node.js 24 to match the lock file generated by npm on Node.js 24. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
