Refactor RFID code to add 0-leading to bytes when building tagID #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've tested the RFID example and found that when RFID tags contain bytes smaller than 16 (0x10) the resulting tagID is not correct. The Hex concat is not including the zero leading those bytes. The output hex tagID looses some characters. for example the bytes A4 B2 63 05 will result in a tagID of A4B2635 (missing the 0) (should be 8 characters long A4B26305).
This pull request fixes the issue buy testing each byte before concatenation and adding the leading 0 if needed.