FEATURE: Localization fallbacks (server-side) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FallbackLocaleList object tells I18n::Backend::Fallbacks what order the languages should be attempted in. Because of the translate_accelerator patch, the SiteSetting.default_locale is *not* guaranteed to be fully loaded after the server starts, so a call to ensure_loaded! is added after the locale is set for the current user. The declarations of config.i18n.fallbacks = true in the environment files were actually garbage, because the I18n.default_locale was SiteSetting.default_locale, so there was nothing to fall back to. *derp*
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # user locale, site locale, english | ||
| # TODO - this can be extended to be per-language for a better user experience | ||
| # (e.g. fallback zh_TW to zh_CN / vice versa) | ||
| [locale, SiteSetting.default_locale.to_sym, :en].uniq.compact |
There was a problem hiding this comment.
Bug: Inconsistent Locale Types Break I18n
The FallbackLocaleList#[] method returns an array mixing string and symbol locale types. The locale parameter is returned as-is while SiteSetting.default_locale is converted to a symbol with .to_sym. This type inconsistency causes I18n.ensure_loaded! to store mixed types in @loaded_locales, breaking the .include? checks in translate_accelerator.rb and potentially causing locales to be loaded multiple times or not at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 9
Replicated from ai-code-review-evaluation/discourse-cursor#9
Note
Introduce I18n fallback support with custom order and ensure fallback locales are preloaded; consolidate pluralization init and remove env fallback flags.
config/initializers/i18n.rbto include pluralization and fallbacks, defineFallbackLocaleListwith order[locale, SiteSetting.default_locale, :en], and setI18n.fallbacks.ApplicationController#set_locale, callI18n.fallbacks.ensure_loaded!after settingI18n.locale.I18ntranslate accelerator withensure_loaded!(locale)to lazy-load locales.config.i18n.fallbacks = truefromproduction.rb,profile.rb, and Cloud66production.rb.config/initializers/pluralization.rbinto the newi18n.rb(delete old file).Written by Cursor Bugbot for commit ecfa17b. Configure here.