scale-color $lightness must use $secondary for dark themes #4
Conversation
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| a { | ||
| font-weight: bold; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 70%), scale-color($secondary, $lightness: 30%)); |
There was a problem hiding this comment.
Bug: Light Theme Colors Too Bright
The light theme lightness value was incorrectly changed from 30% to 70% when wrapping in dark-light-choose(). The first argument should preserve the original light theme value of scale-color($primary, $lightness: 30%), not flip it to 70%. This causes the color to be much lighter than intended in light mode.
| .custom-message-length { | ||
| margin: -10px 0 10px 20px; | ||
| color: scale-color($primary, $lightness: 70%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 30%), scale-color($secondary, $lightness: 70%)); |
There was a problem hiding this comment.
Bug: Light Theme Colors Too Dark
The light theme lightness value was incorrectly changed from 70% to 30% when wrapping in dark-light-choose(). The first argument should preserve the original light theme value of scale-color($primary, $lightness: 70%), not flip it to 30%. This causes the color to be much darker than intended in light mode.
| display: inline-block; | ||
| margin-top: 5px; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 50%), scale-color($secondary, $lightness: 50%)); |
There was a problem hiding this comment.
Bug: Light Theme Colors Appear Overly Bright
The light theme lightness value was incorrectly changed from 30% to 50% when wrapping in dark-light-choose(). The first argument should preserve the original value of scale-color($primary, $lightness: 30%), and the dark theme should use scale-color($secondary, $lightness: 70%). This causes the color to be lighter than intended in light mode.
| display: inline-block; | ||
| margin-top: 5px; | ||
| color: scale-color($primary, $lightness: 30%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 50%), scale-color($secondary, $lightness: 50%)); |
There was a problem hiding this comment.
Bug: Light Theme Colors Appear Too Bright
The light theme lightness value was incorrectly changed from 30% to 50% when wrapping in dark-light-choose(). The first argument should preserve the original value of scale-color($primary, $lightness: 30%), and the dark theme should use scale-color($secondary, $lightness: 70%). This causes the color to be lighter than intended in light mode.
| margin-bottom: 4px; | ||
| margin-top: 0; | ||
| color: scale-color($primary, $lightness: 20%); | ||
| color: dark-light-choose(scale-color($primary, $lightness: 50%), scale-color($secondary, $lightness: 50%)); |
There was a problem hiding this comment.
Bug: Theme color lightness is inconsistent.
The light theme lightness value was incorrectly changed from 20% to 50% when wrapping in dark-light-choose(). The first argument should preserve the original value of scale-color($primary, $lightness: 20%), and the dark theme should use scale-color($secondary, $lightness: 80%). This causes the color to be much lighter than intended in light mode.
Test 7
Replicated from ai-code-review-evaluation/discourse-cursor#7
Note
Replaces many scale-color($primary, …) usages with dark-light-choose(…, scale-color($secondary, …)) to properly support dark themes across the app.
scale-color($primary, …)withdark-light-choose(scale-color($primary, …), scale-color($secondary, …))for text, icons, borders, and backgrounds._topic-list.scss,topic-post.scss(desktop/mobile),desktop/topic-list.scss,desktop/topic.scss.base/header.scss,desktop/header.scss, dropdowns, notifications, search blurb/highlights.base/login.scss,desktop/login.scss,mobile/login.scss, hints/descriptions.common/admin/admin_base.scss(descriptions, badges, filters, lists, borders).components/badges.css.scss,buttons.css.scss).desktop/modal.scss,mobile/modal.scss,desktop/compose.scss,mobile/compose.scss.base/search.scss,base/share_link.scss.base/user.scss,desktop/user.scss,mobile/user.scss, user badges.Written by Cursor Bugbot for commit d38c4d5. Configure here.