Adding support for AiiDA monitors #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannipizzi
force-pushed
the
add_monitor_support
branch
from
2cf6a45 to
26e8c0e
Compare
Now launch_shell_job allows to optionally set monitors which are simply passed to the underlying builder. Also, I am slighly adapting tests to ensure they can also run on a default MacOS machine (where default paths for common bash commands are a bit different, as well as the behaviour of some commands, such as the available flags of the `date` command...)
giovannipizzi
force-pushed
the
add_monitor_support
branch
from
26e8c0e to
4c437b8
Compare
GeigerJ2
approved these changes
Nov 10, 2025
| metadata: dict[str, t.Any] | None = None, | ||
| submit: bool = False, | ||
| resolve_command: bool = True, | ||
| monitors: dict[str, Data] | None = None, |
There was a problem hiding this comment.
This should be Dict, no?
Suggested change
| monitors: dict[str, Data] | None = None, | |
| monitors: dict[str, Dict] | None = None, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now launch_shell_job allows to optionally set monitors which are simply passed to the underlying builder.
Also, I am slighly adapting tests to ensure they can also run on a default MacOS machine (where default paths for common bash commands are a bit different, as well as the behaviour of some commands, such as the available flags of the
datecommand...)