Add option to use bot mention as prefix#302
Open
SuSeu1414 wants to merge 2 commits intoaikar:masterfrom
Open
Conversation
MiniDigger
reviewed
Nov 16, 2020
|
|
||
| String[] args = ACFPatterns.SPACE.split(msg.substring(prefixFound.length()), -1); | ||
| // str.replaceAll("^[ \t]+", "") - works like String.stripLeading() from Java 11 | ||
| String[] args = ACFPatterns.SPACE.split(msg.substring(prefixFound.length()).replaceAll("^[ \\t]+", ""), -1); |
Contributor
There was a problem hiding this comment.
I would say that this pattern should be cached
Contributor
Author
There was a problem hiding this comment.
Ok, now I'm using ACFPatterns.getPattern() which caches patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an option to use bot mention as a command prefix. Might be useful when you have per-server prefixes and forget what prefix is used in a particular server. You can enable it with this code:
It's disabled by default, so it won't change any behaviour until you turn it on