feat: Consumer passthrough of raw payloads as byte arrays #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
commented
Oct 17, 2025
| if (method.getParameterTypes.last.isSealed) { | ||
| method.getParameterTypes.last.getPermittedSubclasses.toList | ||
| if (inputType.isSealed) { | ||
| inputType.getPermittedSubclasses.toList |
Contributor
Author
There was a problem hiding this comment.
Unrelated boyscouting
johanandren
commented
Oct 17, 2025
| AnySupport.typeUrlToContentType( | ||
| "type.googleapis.com/google.protobuf.BytesValue") shouldEqual "application/grpc+proto; message=google.protobuf.BytesValue" | ||
| AnySupport.typeUrlToContentType("json.akka.io/multiplied") shouldEqual "application/json; type=multiplied" | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We should probably move this into runtime consumer logic, the application/vnd.kalix.protobuf.any datacontenttype is a runtime implementation detail.
aludwiko
reviewed
Oct 27, 2025
| // Note: this doesn't really make sense for an event sourced entity, but is easier to test than | ||
| // for a service to service | ||
| // or topic which are sensible use cases for raw payloads | ||
| public Effect raw(byte[] bytes) { |
Contributor
There was a problem hiding this comment.
Is that correct to allow for a raw bytes handler mixed with a specific event type handler?
Contributor
Author
There was a problem hiding this comment.
It's a bit weird, but would allow something like a topic where some messages are json and some are some byte payload. I don't think it hurts or complicates anything allowing it.
johanandren
force-pushed
the
wip-arbitrary-raw-payload-to-consumer
branch
from
62cfc35 to
b641753
Compare
aludwiko
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't decide if it should be shown in reference docs or not.