Skip to content

chore: Proper (hidden) setting for showing provided components #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

chore: Proper (hidden) setting for showing provided components #1109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion akka-javasdk/src/main/scala/akka/javasdk/impl/SdkRunner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ private final class Sdk(
private var guardrailEnabledForComponent = Map.empty[String, Set[String]]

private def isProvided(clz: Class[_]): Boolean = {
sys.props.get("akka.javasdk.dev-mode.show-hidden-components").isEmpty &&
!sdkSettings.devModeSettings.exists(_.showProvidedComponents) &&
ComponentLocator.providedComponents.contains(clz)
}

Expand Down
11 changes: 9 additions & 2 deletions akka-javasdk/src/main/scala/akka/javasdk/impl/Settings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,20 @@ import Settings.DevModeSettings
private[impl] object Settings {

def apply(sdkConfig: Config): Settings = {
val showProvidedComponents = {
val key = "dev-mode.show-hidden-components"
// hidden config, not in reference.conf
if (sdkConfig.hasPath(key)) sdkConfig.getBoolean(key) else false
}

Settings(devModeSettings = Option.when(sdkConfig.getBoolean("dev-mode.enabled"))(
DevModeSettings(
serviceName = sdkConfig.getString("dev-mode.service-name"),
httpPort = sdkConfig.getInt("dev-mode.http-port"))))
httpPort = sdkConfig.getInt("dev-mode.http-port"),
showProvidedComponents)))
}

final case class DevModeSettings(serviceName: String, httpPort: Int)
final case class DevModeSettings(serviceName: String, httpPort: Int, showProvidedComponents: Boolean)
}

/**
Expand Down