-
Notifications
You must be signed in to change notification settings - Fork 0
80 add initial slurm scripts #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
resolves #80 |
sgreenbury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @EdwinB12! I added some small suggestions for the sbatch params, ordering and outputs.
Co-authored-by: Sam Greenbury <[email protected]>
… venv setup Co-authored-by: Sam Greenbury <[email protected]>
|
Okay thanks Sam, made changes and it works. The only thing about removing the sbatch flags at the top with the error and output logs is that the jobs now write some incomplete slurm logs to the cwd which could be misleading. |
Great and good point about the outputs - would moving the working dir creation and redirection to after the |
Two example slurm scripts for running the autoencoder and encoder-processor-decoder setup.
I haven't managed to integrate this with wandb yet but will once I get access to the turing org.
Hopefully the readme explains the rest :)