Fix for quick unmount and remounts #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a case where I am intentionally unmounting and remounting before the debounce gets run in the call stack. And I get errors from react telling me I have a memory leak. This makes that error go away.
markhicken
reviewed
Apr 22, 2021
| const truncatedString = this.getTruncateString(this.props.text) | ||
| this.setState({truncatedString, truncating: false}) | ||
| }) | ||
| if (this._isMounted) { |
There was a problem hiding this comment.
One other approach here, might be to change debounce to a this.timeoutId = setTimeout(...). When the component unmounts you can just clearTimeout(this.timeoutId) so this function never fires.
markhicken
approved these changes
Apr 22, 2021
albinotonnina
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where I am intentionally unmounting and remounting before the debounce gets run in the call stack. And I get errors from react telling me I have a memory leak. This makes that error go away.