details shortcode: add example of both alternatives #783
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
readme: mention steps shortcode, move katex alpha order steps: use 1. instead of fixed numbers
|
no idea why the checks are failing , works fine locally with huge 0.151.1 |
alex-shpak
reviewed
Oct 21, 2025
| keyword or set `open=false`. | ||
|
|
||
| ## Example | ||
| ## Example 1 |
There was a problem hiding this comment.
I think it would be better as ## Example with positional arguments
alex-shpak
reviewed
Oct 21, 2025
| Lorem markdownum insigne... | ||
| {{% /details %}} | ||
|
|
||
| ## Example 2 |
There was a problem hiding this comment.
Same here, I think it would be better as ## Example with parameters
alex-shpak
reviewed
Oct 21, 2025
| ... | ||
| 2. ## Maecenas scelerisque sem. | ||
| 1. ## Maecenas scelerisque sem. |
alex-shpak
reviewed
Oct 21, 2025
| Suspendisse sed congue orci, eu congue metus. Nullam feugiat urna massa, et fringilla metus consectetur molestie. Curabitur pellentesque sodales ipsum, sed efficitur libero euismod ac. Donec sit amet erat nunc. Suspendisse porta nisl velit, quis auctor massa commodo nec. Donec sollicitudin tellus sit amet massa condimentum luctus. Etiam molestie at ante et convallis. | ||
|
|
||
| 2. ## Maecenas scelerisque sem. | ||
| 1. ## Maecenas scelerisque sem. |
|
Left few comments, otherwise looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme: mention steps shortcode, move katex alpha order
steps: use 1. instead of fixed numbers