Skip to content

Conversation

@sbellone
Copy link
Collaborator

@sbellone sbellone commented Oct 7, 2024

If you currently run the demo without Recommend, the popup doesn't display because the recommend index isn't found.

Since Recommend is complex to setup, I propose to not rely on it by default, so anyone can run the demo more easily.

This PR uses the same approach than #31 to fetch the most popular brand facets from the search results.
I'm also leaving the recommend code commented to give pointer about how to integrate Recommend.

Note: since our demo index is not fully trained, this approach actually works better:

  • the current demo displays Lacy-D, Arlene and Lacy-S
  • locally I now get Apple, Sony, Lacy-D and Garmin

SFCC-389

@sbellone sbellone requested a review from htuzel October 7, 2024 14:12
@sbellone sbellone self-assigned this Oct 7, 2024
@sbellone sbellone merged commit 72a5168 into develop Oct 14, 2024
2 checks passed
@sbellone sbellone deleted the fix/dont-require-recommend branch October 14, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants