Skip to content

Support ShadowDOM #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support ShadowDOM #555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2f1eb2
Support ShadowDOM
mantou132 Feb 23, 2022
8d6104f
chore: use `getHTML`
mantou132 Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/lib/browser/Page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,23 @@
return await promiseWithTimeout(
(async (): Promise<string | null> => {
const start = Date.now();
const content = await this.#ref?.content();
Copy link
Author

@mantou132 mantou132 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page.content(): https://github.com/microsoft/playwright/blob/19a4f15eb67fd82a0b78b12dd94e3564504f83f9/packages/playwright-core/src/server/frames.ts#L866

const content = await this.#ref?.evaluate(() => {
const doctype = document.doctype
? new XMLSerializer().serializeToString(document.doctype)
: '';
// https://html.spec.whatwg.org/#dom-parsing-and-serialization
if (!('getHTML' in Element.prototype)) {
return `${doctype}${document.documentElement.outerHTML}`;
}
const body = (document.body as any).getHTML({ serializableShadowRoots: true });
const uid = crypto.randomUUID();
document.body.innerHTML = uid;

Check failure on line 284 in src/lib/browser/Page.ts

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/lib/browser/Page.ts#L284 

User controlled data in a `document.body.innerHTML` is an anti-pattern that can lead to XSS vulnerabilities

Check failure on line 284 in src/lib/browser/Page.ts

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/lib/browser/Page.ts#L284 

User controlled data in methods like `innerHTML`, `outerHTML` or `document.write` is an anti-pattern that can lead to XSS vulnerabilities
return `${doctype}${document.documentElement.outerHTML.replace(
uid,
body
)}`;
});

stats.timing('renderscript.renderBody', Date.now() - start, {
browser: this.#engine as string,
});
Expand Down