test: use algokit-polytest go-algorand transaction generator #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickDinh
reviewed
Dec 17, 2025
packages/transact/tests/common.ts
Outdated
| key, | ||
| { | ||
| id: value.id, | ||
| transaction: new Transaction(transformTransaction(value.stxn.txn)), |
Contributor
There was a problem hiding this comment.
I think having an independence function here will allow us to test the transaction encode/decode in isolation but I'm a bit concern about the maintenance effort. In the past, debugging issues when converting JSON -> transaction was a time consuming process.
I'm wondering should we use the transaction codec directly here? In my test, switching to use the codec as below
transaction: new Transaction(transactionParamsCodec.decode(value.stxn.txn, 'json')),
all the tests still pass.
Contributor
Author
There was a problem hiding this comment.
in 297dccd I have updated it to use the codec. Note that I did have to add numeric map keys support for JSON, which encodes bigints as strings in the JSON
joe-p
force-pushed
the
decoupling-test/transact_polytest
branch
from
a32dea8 to
5d982cb
Compare
PatrickDinh
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the data factory from algorandfoundation/algokit-polytest#19
We should probably merge the algokit-polytest PR first so we can point the to
algokit-polytest#main