Skip to content

Conversation

@KrosFire
Copy link
Member

@KrosFire KrosFire commented Nov 9, 2025

No description provided.

@KrosFire KrosFire changed the base branch from master to amber-0.5 November 9, 2025 18:01
@KrosFire KrosFire requested a review from Copilot November 9, 2025 18:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test snapshots to reflect changes in tokenization behavior where adjacent text tokens are now being merged into single tokens. The change appears to consolidate token sequences that previously split text/symbols/paths/commands into individual tokens, now combining them into fewer, larger tokens for improved efficiency.

Reviewed Changes

Copilot reviewed 241 out of 253 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/grammar/snapshots/r#mod__grammar__alpha050__unfinished_function_call.snap Updates snapshots for path and filename tokenization to merge tokens like "std"/"/"/"array" into "std/array"
tests/grammar/snapshots/r#mod__grammar__alpha050__unfinished_function_call-2.snap Similar path token merging updates for parsed output
tests/grammar/snapshots/r#mod__grammar__alpha050__stdlib_text.snap Extensive token merging for shell commands, escape sequences, and text patterns
tests/grammar/snapshots/r#mod__grammar__alpha050__stdlib_text-2.snap Corresponding parsed output updates with merged text nodes
tests/grammar/snapshots/r#mod__grammar__alpha050__stdlib_math.snap Token merging for mathematical expressions and shell commands
tests/grammar/snapshots/r#mod__grammar__alpha050__stdlib_http.snap Merges command-line options and arguments into single tokens
tests/grammar/snapshots/r#mod__grammar__alpha050__stdlib_date.snap Date format string and command token consolidation
tests/grammar/snapshots/r#mod__grammar__alpha050__numbers.snap New snapshot file for number literal parsing
tests/grammar/snapshots/r#mod__grammar__alpha050__mv_files.snap Path token merging for file operations
tests/grammar/snapshots/r#mod__grammar__alpha050__comments_in_ifs.snap Text consolidation in conditional statements
Alpha040/035/034 snapshots Similar token merging updates for older grammar versions
src/utils.rs Formatting change to split import statement into multiple lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

❌ Patch coverage is 81.39905% with 117 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/grammar/alpha050/lexer.rs 76.00% 36 Missing ⚠️
src/grammar/alpha035/lexer.rs 78.32% 31 Missing ⚠️
src/grammar/alpha040/lexer.rs 79.02% 30 Missing ⚠️
src/grammar/alpha034/lexer.rs 86.01% 20 Missing ⚠️

📢 Thoughts on this report? Let us know!

Base automatically changed from amber-0.5 to master November 10, 2025 14:19
@KrosFire KrosFire requested a review from Copilot November 10, 2025 14:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 296 out of 407 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KrosFire KrosFire merged commit 3dd97e9 into master Nov 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants