Added improvements to stdlib #821
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type safety and code clarity in the standard library by adding explicit type annotations to function parameters and renaming variables to avoid naming conflicts.
- Added explicit type annotations to previously untyped function parameters
- Renamed parameter
replacetoreplace_textinreplace_regexto avoid shadowing thereplacefunction - Added explicit cast in
array_filledto ensure type consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/std/text.ab | Renamed parameter replace to replace_text to avoid shadowing the global replace function |
| src/std/math.ab | Added explicit Num type annotation to the number parameter in math_abs |
| src/std/array.ab | Added type annotations to array_extract_at parameters and explicit cast in array_filled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ph0enixKM
requested changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ph0enixKM
approved these changes
Nov 15, 2025
lens0021
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are a result of new version of amber lsp dedicated to this amber version. Thanks to these changes, users will have a better experience when using stdlib