Fix behavioral incompatibility between PsrMessageStream and StreamInterface #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luzrain
force-pushed
the
stream_interface_compatibility
branch
2 times, most recently
from
6af87c2 to
07d5ff4
Compare
luzrain
force-pushed
the
stream_interface_compatibility
branch
from
07d5ff4 to
deda3d4
Compare
luzrain
changed the title
Contributor
Author
|
@kelunik please take a look at this pr when you get a chance. |
Contributor
Author
|
@kelunik ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes a behavioral incompatibility between
PsrMessageStreamandPsr\Http\Message\StreamInterface.The
read()method incorrectly throw an exception upon reaching the end of the stream. According to the interface contract, it should return an empty string instead. See StreamInterface docs here.The
isReadable()method incorrectly returned false at end of file, whereas it should continue to return true. See the default implementation of GuzzleHttp\Psr7\Stream.php - it stays readable by reaching end of file.These issues caused compatibility problems with components relying on
Psr\Http\Message\StreamInterface- for example, Guzzle's CachingStream fails when used withPsrMessageStreamnow.